Group dependabot created updates for some packages in fewer PRs #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
|
Maybe also group fontawesome deps? |
absidue
reviewed
Aug 29, 2023
|
Would also like to see a group for stylelint:
so these patterns should work: stylelint:
patterns:
- "stylelint"
- "stylelint-*"
- "postcss"
- "postcss-scss"
- "@double-great/stylelint-a11y" |
|
@ChunkyProgrammer @absidue added |
absidue
approved these changes
Aug 31, 2023
ChunkyProgrammer
approved these changes
Aug 31, 2023
|
@efb4f5ff-1298-471a-8973-3d47447115dc Just get this merged... |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 5, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 5, 2023
* development: (66 commits) Group dependabot created updates for some packages in fewer PRs (FreeTubeApp#3968) Chore: Update vscode configurations (FreeTubeApp#3986) Bump youtubei.js from 6.1.0 to 6.3.0 (FreeTubeApp#3994) Bump postcss from 8.4.28 to 8.4.29 (FreeTubeApp#3995) Bump @babel/preset-env from 7.22.10 to 7.22.14 (FreeTubeApp#3996) Bump marked from 7.0.5 to 8.0.0 (FreeTubeApp#3993) Bump electron-builder from 24.6.3 to 24.6.4 (FreeTubeApp#3992) Translated using Weblate (Italian) Translated using Weblate (Dutch) Translated using Weblate (Swedish) Translated using Weblate (Swedish) Translated using Weblate (Dutch) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Japanese) Translated using Weblate (Romanian) Translated using Weblate (Estonian) Compressed Images (FreeTubeApp#3988) Translated using Weblate (Hungarian) Translated using Weblate (Hungarian) Translated using Weblate (Czech) ... # Conflicts: # package.json
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 7, 2023
* development: Add button to pause playlist after current video (FreeTubeApp#3938) Translated using Weblate (Greek) Translated using Weblate (Lithuanian) Translated using Weblate (Swedish) Translated using Weblate (Catalan) Make ft-channel-bubble an actual link when it is being used as one (FreeTubeApp#3980) Translated using Weblate (Catalan) Translated using Weblate (Catalan) Translated using Weblate (French) Bump lefthook from 1.4.9 to 1.4.10 (FreeTubeApp#4003) Bump the babel group with 3 updates (FreeTubeApp#4000) Bump actions/checkout from 3 to 4 (FreeTubeApp#3999) Group dependabot created updates for some packages in fewer PRs (FreeTubeApp#3968) Chore: Update vscode configurations (FreeTubeApp#3986) Bump youtubei.js from 6.1.0 to 6.3.0 (FreeTubeApp#3994) Bump postcss from 8.4.28 to 8.4.29 (FreeTubeApp#3995) Bump @babel/preset-env from 7.22.10 to 7.22.14 (FreeTubeApp#3996) Bump marked from 7.0.5 to 8.0.0 (FreeTubeApp#3993) Bump electron-builder from 24.6.3 to 24.6.4 (FreeTubeApp#3992) # Conflicts: # src/renderer/views/Watch/Watch.js
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 7, 2023
* feature/playlist-2023-05: (25 commits) ! Fix prompt style issue caused by old branch changes * Update single playlist view to only show `Remove watched videos` btn when there is any video Add button to pause playlist after current video (FreeTubeApp#3938) Translated using Weblate (Greek) Translated using Weblate (Lithuanian) Translated using Weblate (Swedish) Translated using Weblate (Catalan) Make ft-channel-bubble an actual link when it is being used as one (FreeTubeApp#3980) $ Remove unused and unusable playlist code for inserting video IDs into a playlist $ Remove unused mapActions entries * Make adding large no. of videos faster Translated using Weblate (Catalan) Translated using Weblate (Catalan) Translated using Weblate (French) Bump lefthook from 1.4.9 to 1.4.10 (FreeTubeApp#4003) Bump the babel group with 3 updates (FreeTubeApp#4000) Bump actions/checkout from 3 to 4 (FreeTubeApp#3999) Group dependabot created updates for some packages in fewer PRs (FreeTubeApp#3968) Chore: Update vscode configurations (FreeTubeApp#3986) Bump youtubei.js from 6.1.0 to 6.3.0 (FreeTubeApp#3994) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
N/A
Description
We can now group dependabot created updates together
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups
We can discuss what/how to be grouped together
But I do feel the swamp of PRs every week for some of the related packages seems too many (especially with several repos)
And I am not sure if this reduce the chance of code conflicts after merging PRs (but we don't have that many yet I guess)
Screenshots
List of seems related packages' updates recently
Example 1:
babelhttps://github.com/FreeTubeApp/FreeTube/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A"PR%3A+dependencies"+is%3Amerged+babel
Example 2:
eslinthttps://github.com/FreeTubeApp/FreeTube/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22PR%3A+dependencies%22+is%3Amerged+eslint
Example 3:
fontawesomehttps://github.com/FreeTubeApp/FreeTube/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22PR%3A+dependencies%22+is%3Amerged+fontawesome+
Testing
NO idea
Desktop
Additional context